Skip to content

Commit

Permalink
PR #19660: [ROCm] switch rocm build to clang
Browse files Browse the repository at this point in the history
Imported from GitHub PR #19660

This PR switches the default rocm build to clang as the gcc config is broken at the moment.

Copybara import of the project:

--
ea48f7c by Alexandros Theodoridis <[email protected]>:

[ROCm] switch rocm build to clang

--
2743fab by Alexandros Theodoridis <[email protected]>:

Remove explicit clang path from the bazelrc rocm config

--
202dea0 by Alexandros Theodoridis <[email protected]>:

Address review comments

Merging this change closes #19660

COPYBARA_INTEGRATE_REVIEW=#19660 from ROCm:ci_switch_rocm_build_to_clang 202dea0
PiperOrigin-RevId: 699222609
  • Loading branch information
alekstheod authored and Google-ML-Automation committed Nov 22, 2024
1 parent 46f14cf commit 9bd5fac
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,14 @@ build:rocm --define=using_rocm_hipcc=true
build:rocm --define=tensorflow_mkldnn_contraction_kernel=0
build:rocm --repo_env TF_NEED_ROCM=1

build:rocm_clang_official --config=rocm
build:rocm_clang_official --action_env=CLANG_COMPILER_PATH="/usr/lib/llvm-18/bin/clang"
build:rocm_clang_official --action_env=TF_ROCM_CLANG="1"
build:rocm_clang_official --linkopt="-fuse-ld=lld"
build:rocm_clang_official --host_linkopt="-fuse-ld=lld"

build:rocm_ci --config=rocm_clang_official

build:sycl --crosstool_top=@local_config_sycl//crosstool:toolchain
build:sycl --define=using_sycl=true
build:sycl --define=tensorflow_mkldnn_contraction_kernel=0
Expand Down
8 changes: 8 additions & 0 deletions third_party/tsl/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,14 @@ build:rocm --define=using_rocm_hipcc=true
build:rocm --define=tensorflow_mkldnn_contraction_kernel=0
build:rocm --repo_env TF_NEED_ROCM=1

build:rocm_clang_official --config=rocm
build:rocm_clang_official --action_env=CLANG_COMPILER_PATH="/usr/lib/llvm-18/bin/clang"
build:rocm_clang_official --action_env=TF_ROCM_CLANG="1"
build:rocm_clang_official --linkopt="-fuse-ld=lld"
build:rocm_clang_official --host_linkopt="-fuse-ld=lld"

build:rocm_ci --config=rocm_clang_official

build:sycl --crosstool_top=@local_config_sycl//crosstool:toolchain
build:sycl --define=using_sycl=true
build:sycl --define=tensorflow_mkldnn_contraction_kernel=0
Expand Down

0 comments on commit 9bd5fac

Please sign in to comment.