Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Implement hermetic rocm dependency #19649

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
+1,014 −203
Open

[ROCm] Implement hermetic rocm dependency #19649

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
49a09a9
Implement hermetic rocm dependency
alekstheod Oct 31, 2024
747cabb
Fix redefenition in rocm_configure
alekstheod Nov 21, 2024
e6d1d04
Fix invalid list of ubuntu 22_04
alekstheod Nov 21, 2024
844867e
Add missing dependency to rocprofiler-register
alekstheod Nov 26, 2024
42e4cbd
Add missing deps
alekstheod Nov 27, 2024
b5189f5
Add missing sys dependencies
alekstheod Nov 27, 2024
b1c5e1c
Clean up visibility
alekstheod Nov 28, 2024
3ec26f9
Add missing rocm_smi dependency
alekstheod Nov 28, 2024
dea57b9
Use bazel build mirrors for system libs
alekstheod Nov 29, 2024
e714e84
Fix rocm deps redist
alekstheod Dec 2, 2024
d3db2bd
Use linkopts
alekstheod Dec 2, 2024
86d1742
Fix after rebase
alekstheod Dec 2, 2024
c4672b6
Fix compiler detection
alekstheod Dec 2, 2024
8cb976b
Use linkopts
alekstheod Dec 2, 2024
80e1a09
Fix rpaths
alekstheod Dec 3, 2024
62ac561
Fix dependency based on rocm config
alekstheod Dec 3, 2024
b12fc37
Make loader static
alekstheod Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions third_party/tsl/third_party/gpus/crosstool/BUILD.rocm.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ filegroup(
)

filegroup(
name = "crosstool_wrapper_driver_is_not_gcc",
srcs = ["clang/bin/crosstool_wrapper_driver_is_not_gcc"],
name = "crosstool_wrapper_driver_is_not_gcc",
srcs = [":clang/bin/crosstool_wrapper_driver_is_not_gcc"],
data = ["@local_config_rocm//rocm:all_files"],
)

1 change: 1 addition & 0 deletions third_party/tsl/third_party/gpus/crosstool/clang/bin/crosstool_wrapper_driver_rocm.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ def InvokeHipcc(argv, log=False):
hipccopts += defines
hipccopts += std_options
hipccopts += m_options
hipccopts += ' --rocm-path="%{rocm_path}" '

if depfiles:
# Generate the dependency file
Expand Down
Loading