Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trip-form): close mode button before setting submode options to default #791

Conversation

josh-willis-arcadis
Copy link
Contributor

Uses setTimeout to wait for the mode button animation to complete before setting submode options to their default values.

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and it looks good in OTP-RR, but for some reason it's looking pretty weird on storybook? Is there a way we could fix the animation?

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not the worst hack I've seen

@josh-willis-arcadis josh-willis-arcadis merged commit f22594c into opentripplanner:master Nov 13, 2024
2 checks passed
@josh-willis-arcadis josh-willis-arcadis deleted the deselect-all-mode-button-enhancements branch November 13, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants