Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trip-form): close mode button before setting submode options to default #791

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/trip-form/src/MetroModeSelector/SubSettingsPane.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ export default function SubSettingsPane({

const handleSettingChange = useCallback(
(setting: ModeSetting) => (evt: QueryParamChangeEvent) => {
let time = 0;
// check if setting is a transport mode setting
if (settingsWithTransportMode.find(s => s.key === setting.key)) {
// check if all submodes are disabled
Expand All @@ -210,10 +211,14 @@ export default function SubSettingsPane({
evt[s.key] = Object.keys(evt).includes(s.key) || !s.value;
});
onAllSubmodesDisabled(modeButton);
time = 500;
}
}

onSettingUpdate(evt);
setTimeout(() => {
// This is a hack to make sure the setting is updated before the next render
onSettingUpdate(evt);
}, time);
},
[onSettingUpdate]
);
Expand Down
Loading