Deselect all submodes #1265
Deselect all submodes #1265
Conversation
…o reset to default values
… values of all subsettings
josh-willis-arcadis
changed the base branch from
dev
to
master-trip-form-update
| onToggleModeButton={setModeButton( | ||
| enabledModeButtons, | ||
| onSettingsUpdate(setQueryParam) | ||
| onSettingsUpdate={onAdvancedModeSubsettingsUpdate( |
There was a problem hiding this comment.
What I am uncomfortable with here is that the advanced settings panel already has the mode button that corresponds with the mode setting that is being updated. I don't think we should do a bunch of work to get that mode button item again. It will require an update to the OTP UI component but I think there's a better way to go about this.
There was a problem hiding this comment.
In fact, maybe it would be possible to do this change almost entirely within OTP UI? Could we just add a prop for transportModesDisableCascade? Weird name idk but something like that
josh-willis-arcadis
added
the
BLOCKED
josh-willis-arcadis
removed
the
BLOCKED
josh-willis-arcadis
added
the
BLOCKED
josh-willis-arcadis
removed
the
BLOCKED
daniel-heppner-ibigroup
assigned josh-willis-arcadis and unassigned daniel-heppner-ibigroup
daniel-heppner-ibigroup
force-pushed
the
deselect-all-submodes
branch
from
0648e80 to
8a6bef9
Compare
josh-willis-arcadis
assigned daniel-heppner-ibigroup and unassigned josh-willis-arcadis
daniel-heppner-ibigroup
assigned josh-willis-arcadis and unassigned daniel-heppner-ibigroup
There was a problem hiding this comment.
Curious what you both think of this setTimeout idea @daniel-heppner-ibigroup @josh-willis-arcadis. We can also address in a follow up PR if need be
Description:
When the user deselects all transport submode options(transit and rental), the mode should be disabled. This is reflected in the URL query params. When the mode is enabled after being disabled by deselecting all transport submode options, the defaults are used.
Blocked by opentripplanner/otp-ui#782
PR Checklist: