Fixed workdir for ghdl in template creation #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdefeber
force-pushed
the
fix_ghdl_workdir
branch
13 times, most recently
from
f2260c1
to
fdb602a
Compare
stdefeber
force-pushed
the
fix_ghdl_workdir
branch
from
fdb602a
to
3f454bc
Compare
|
Thank you for this. Generally it looks fine, but there are also some changes in tests/edalize_common.py that I don't see mentioned anywhere (and a removed line in the docs). More problematic is that this patch is against the old tool API version of the ghdl backend. ghdl has been ported to the new Flow API, so this file will eventually be removed and all new development should go in https://github.com/olofk/edalize/blob/main/edalize/tools/ghdl.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per ticket olofk/fusesoc#707