-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make signed URLs for output datasets optional #676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: If calling `Analysis.finalise` manually, either stop doing this and rely on the `output_location` field of the app configuration or explicitly pass in the `upload_output_datasets_to` argument.
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 94.50% 94.59% +0.09%
==========================================
Files 83 83
Lines 3547 3589 +42
==========================================
+ Hits 3352 3395 +43
+ Misses 195 194 -1 ☔ View full report in Codecov by Sentry. |
cortadocodes
changed the title
Make signing output datasets optional
Make signed URLs for output datasets optional
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents (#676)
IMPORTANT: There is 1 breaking change.
Enhancements
requests
errors while:Fixes
Refactoring
output_location
inAnalysis
Upgrade instructions
💥 Stop storing `output_location` in `Analysis`
If calling
Analysis.finalise
manually, either stop doing this and rely on theoutput_location
field of the app configuration or explicitly pass in theupload_output_datasets_to
argument.