Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make signed URLs for output datasets optional #676

Merged
merged 19 commits into from
Aug 15, 2024

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Aug 14, 2024

Contents (#676)

IMPORTANT: There is 1 breaking change.

Enhancements

  • Allow using non-signed URLs for datasets in output manifest (controllable via the app configuration file)
  • Handle all requests errors while:
    • Getting cloud metadata for datafiles and datasets
    • Downloading datafiles

Fixes

  • Avoid trying to access buckets for URL datasets

Refactoring

  • 💥 BREAKING CHANGE: Stop storing output_location in Analysis
  • Remove unnecessary finalisation from template apps

Upgrade instructions

💥 Stop storing `output_location` in `Analysis`

If calling Analysis.finalise manually, either stop doing this and rely on the output_location field of the app configuration or explicitly pass in the upload_output_datasets_to argument.

@cortadocodes cortadocodes self-assigned this Aug 14, 2024
@cortadocodes cortadocodes linked an issue Aug 14, 2024 that may be closed by this pull request
5 tasks
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (9092646) to head (402c8e5).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
+ Coverage   94.50%   94.59%   +0.09%     
==========================================
  Files          83       83              
  Lines        3547     3589      +42     
==========================================
+ Hits         3352     3395      +43     
+ Misses        195      194       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes changed the title Make signing output datasets optional Make signed URLs for output datasets optional Aug 15, 2024
@cortadocodes cortadocodes merged commit fa2cfdf into main Aug 15, 2024
5 checks passed
@cortadocodes cortadocodes deleted the make-signing-output-datasets-optional branch August 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access to output datasets via output manifest expires after 7 days
2 participants