Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to output datasets via output manifest expires after 7 days #675

Closed
5 tasks done
cortadocodes opened this issue Aug 14, 2024 · 1 comment · Fixed by #676
Closed
5 tasks done

Access to output datasets via output manifest expires after 7 days #675

cortadocodes opened this issue Aug 14, 2024 · 1 comment · Fixed by #676
Assignees
Labels
bug Unintended behaviour in any area of the app

Comments

@cortadocodes
Copy link
Member

cortadocodes commented Aug 14, 2024

Bug report

What is the current behavior?

The signed URLs generated for datasets referenced in output manifests expires after 7 days, which denies long term access to datasets. This happens even when the requester has permission to access the output datasets (because unauthenticated signed URLs are used in output manifests instead of authenticated access to gs:// addresses).

What is the expected behavior?

Signed URLs were introduced to allow parents access to output datasets generated by a child which were then stored in the child's bucket where the parent didn't have permission to access that bucket directly (e.g. parents from outside an organisation to access outputs generated by a child inside that organisation).

Proposed Solution

  • For parents and children with access to the same buckets (e.g. inside the same organisation), there should be an option to use gs:// addresses in the output manifest to allow long term authenticated access to output datasets. This could be switched on via an environment variable, the application configuration, or an argument to Service.ask.
  • Consider if this should be the default
  • Add conversion of a signed URL to a gs:// address in the event of failure to retrieve data from it
  • Raise a better error when trying to access a dataset with an expired signed URL
  • Update documentation on finalise and app configuration
@cortadocodes cortadocodes added the bug Unintended behaviour in any area of the app label Aug 14, 2024
@cortadocodes cortadocodes self-assigned this Aug 14, 2024
@cortadocodes
Copy link
Member Author

@thclark I'm interested to know if you think using gs:// paths should be the default? I think it makes sense for most use cases of the sdk

@cortadocodes cortadocodes linked a pull request Aug 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended behaviour in any area of the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant