Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make signed URLs for output datasets optional #676

Merged
merged 19 commits into from
Aug 15, 2024
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
09b7c1b
REF: Remove unnecessary finalisation from template apps
cortadocodes Aug 14, 2024
161b847
ENH: Allow using non-signed URLs for output datasets
cortadocodes Aug 14, 2024
95b522c
REF: Stop storing `output_location` in `Analysis`
cortadocodes Aug 14, 2024
77d890e
FIX: Fix analysis finalisation when there are no output datasets
cortadocodes Aug 14, 2024
ec89235
TST: Test `Analysis.finalise` without using signed URLs
cortadocodes Aug 14, 2024
45697d1
ENH: Promote log message to info
cortadocodes Aug 14, 2024
36bd91b
REF: Remove unnecessary analysis finalisation from other template apps
cortadocodes Aug 14, 2024
04dcc06
TST: Simplify analysis test
cortadocodes Aug 15, 2024
282dec2
DOC: Add missing param strings in docstrings
cortadocodes Aug 15, 2024
a79b7ed
ENH: Handle all `requests` errors in `Dataset._get_cloud_metadata`
cortadocodes Aug 15, 2024
5a50648
ENH: Handle `requests` errors for URL-based datafiles
cortadocodes Aug 15, 2024
abbc1ec
ENH: Include `requests` exception in log messages
cortadocodes Aug 15, 2024
7d4013d
FIX: Raise for non-200 responses in URL datafile download
cortadocodes Aug 15, 2024
ebdc7a3
TST: Test working with inaccessible URL datafiles
cortadocodes Aug 15, 2024
01a2db0
TST: Test working with inaccessible URL datasets
cortadocodes Aug 15, 2024
79d85f5
ENH: Improve log message
cortadocodes Aug 15, 2024
402c8e5
FIX: Avoid trying to access buckets for URL datasets
cortadocodes Aug 15, 2024
888e052
DOC: Update app configuration docs
cortadocodes Aug 15, 2024
42940d1
CHO: Add version compatibility metadata
cortadocodes Aug 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ENH: Improve log message
cortadocodes committed Aug 15, 2024
commit 79d85f5a7235b552034501159ad7e5d5e93bcee1
2 changes: 1 addition & 1 deletion octue/resources/dataset.py
Original file line number Diff line number Diff line change
@@ -491,7 +491,7 @@ def _get_cloud_metadata(self):
self._cloud_metadata = requests.get(self.path).json()
except requests.exceptions.RequestException:
logger.exception(
"Couldn't access cloud dataset metadata file at %r; proceeding without cloud metadata.",
"Couldn't access cloud dataset metadata for %r; proceeding without cloud metadata.",
self.path,
)