Bug fixes for offline support

[rapterjet2004]

• Fix duplicate messages
• Fix duplicate conversations
• Fix crashes on empty conversations
• Unable to Join open conversations
• Fix Unread messages not showing up correctly when entering a conversation see Bug fixes for offline support #4069 (review)
• Delete all messages sometimes stops the UI from updating. Might be an issue with initMessagePolling

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[rapterjet2004]

See

#3952 (comment)
#3952 (comment)

[niclasheinz]

I would like to add the following to this comment #3952 (comment):

• Storage Manager:
  Here you can set after how many weeks/months/years the chat messages/media files are automatically deleted locally.

• Global settings:

  • Activate/deactivate offline support
  • Decide what is made available offline:
    • Messages
    • Media files such as images Documents
    • audios
    • surveys
    • Locations
    • Contacts

The same settings can be overwritten or adjusted in the individual chats.

[rapterjet2004]

/backport to stable-20.0

[sowjanyakch]

The following has to be fixed.

1. Unable to join open conversations.
2. Delete messages of a conversation [Note to Self/ Group messages], then send a message. UI is not updated.

[AndyScherzinger]

@rapterjet2004 Also broken atm is scrolling to the oldest unread message when entering a talk room with unread messages. Currently it simply renders right at the end of the conversation.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	86	86
Errors	131	131

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	11	11
Dodgy code	78	78
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	6	6
Security	1	1
Total	108	108

[mahibi]

There is a difference between lastReadMessage and lastCommonRead. The code in this PR mixes these things which creates new bugs. @rapterjet2004 Would you mind to revert everything to "Fix Unread messages not showing up correctly when entering a conversation" and i will fix it in a separate PR?

[mahibi]

I would like to add the following to this comment #3952 (comment):

* Storage Manager:
  Here you can set after how many weeks/months/years the chat messages/media files are automatically deleted locally.

* Global settings:
  
  * Activate/deactivate offline support
  * Decide what is made available offline:
    
    * Messages
    * Media files such as images Documents
    * audios
    * surveys
    * Locations
    * Contacts

The same settings can be overwritten or adjusted in the individual chats.

Thank you for the ideas @niclasheinz , some of them may be implemented in the future.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4069-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.