NPE in ConversationMapUtilsKt.asModel

[mahibi]

app version 20.0.0RC1

from gplay console. happened to 36 users so far:

Exception java.lang.NullPointerException:
  at com.nextcloud.talk.data.database.mappers.ConversationMapUtilsKt.asModel
  at com.nextcloud.talk.conversationlist.data.network.OfflineFirstConversationsRepository.getConversation (OfflineFirstConversationsRepository.kt:112)
  at com.nextcloud.talk.conversationlist.data.network.OfflineFirstConversationsRepository.access$getConversation (OfflineFirstConversationsRepository.kt:34)
  at com.nextcloud.talk.conversationlist.data.network.OfflineFirstConversationsRepository$getConversation$1.invokeSuspend
  at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)
  at kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:102)
  at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run (LimitedDispatcher.kt:111)
  at kotlinx.coroutines.scheduling.TaskImpl.run (Tasks.kt:99)
  at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely (CoroutineScheduler.kt:584)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask (CoroutineScheduler.kt:811)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker (CoroutineScheduler.kt:715)
  at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.kt:702)

[rapterjet2004]

    private suspend fun getConversation(accountId: Long, token: String): ConversationModel {
        val entity = dao.getConversationForUser(accountId, token).first()
        return entity.asModel()
    }

The issue is with getConversation where the asModel mapping function was called on a conversation that didn't exist, which should have been fixed in the recently merged #4069 which added null safety and loaded the conversation to storage if not found.

+ private suspend fun getConversation(accountId: Long, token: String): ConversationModel? {
    val entity = dao.getConversationForUser(accountId, token).first()
+   return entity?.asModel()
}