Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up bug fixes for offline support #4157

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 5, 2024

manual backport of #4069

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Got join conversation to work
Unread message popup should work when entering a conversation now
"Delete All Messages" now works without breaking the initMessagePolling
linter

Signed-off-by: rapterjet2004 <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi merged commit 6526908 into stable-20.0 Sep 5, 2024
12 of 17 checks passed
@mahibi mahibi deleted the backport/4069/offline-support-bug-fixes branch September 5, 2024 13:56
@mahibi mahibi added this to the 20.0.0 milestone Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Codacy

Lint

TypemasterPR
Warnings8687
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

Copy link
Contributor

github-actions bot commented Sep 5, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4157-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants