Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename histology to anat and move to session level. #229

Merged
merged 10 commits into from
Oct 24, 2023
Merged

Rename histology to anat and move to session level. #229

merged 10 commits into from
Oct 24, 2023

Conversation

JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented Oct 20, 2023 •
edited
Loading

Further to Neuroblueprint change #299 this PR renames histology to anat and moves it to the session level.

@JoeZiminski JoeZiminski force-pushed the rename_and_move_histology branch from 4e806c3 to 109ef1f Compare October 21, 2023 13:29
@JoeZiminski JoeZiminski changed the base branch from main to remove_use_datatype October 23, 2023 10:32
@JoeZiminski JoeZiminski mentioned this pull request Oct 23, 2023
Merged
@JoeZiminski JoeZiminski requested a review from niksirbi October 23, 2023 11:04
niksirbi
niksirbi requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example project trees in documentaiton and in README have to be changed so that they show anat at the session level.

There is also one lingering mention of "histological" in documentation.md line 79 (should be "anatomical")

docs/source/pages/documentation.md Outdated Show resolved Hide resolved
docs/source/pages/documentation.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
@JoeZiminski JoeZiminski force-pushed the rename_and_move_histology branch from 36c090a to b8cfda8 Compare October 24, 2023 11:35
@JoeZiminski JoeZiminski force-pushed the rename_and_move_histology branch 3 times, most recently from ef65b34 to 7760ea6 Compare October 24, 2023 12:12
Base automatically changed from remove_use_datatype to main October 24, 2023 12:30
@JoeZiminski JoeZiminski force-pushed the rename_and_move_histology branch from 7760ea6 to 829ec80 Compare October 24, 2023 12:38
@JoeZiminski
Copy link
Member Author

Thanks @niksirbi! the comments are addressed, I just realised there are some minor formatting issues with the tree connectors, but these are minor and are fixed in #207.

@niksirbi niksirbi self-requested a review October 24, 2023 13:47
@JoeZiminski JoeZiminski merged commit c02a68f into main Oct 24, 2023
16 checks passed
@JoeZiminski JoeZiminski deleted the rename_and_move_histology branch October 24, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niksirbi niksirbi niksirbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeZiminski @niksirbi