multiple geometry staging #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 84.49% 83.17% -1.32%
==========================================
Files 88 100 +12
Lines 2676 3007 +331
Branches 271 315 +44
==========================================
+ Hits 2261 2501 +240
- Misses 351 430 +79
- Partials 64 76 +12 ☔ View full report in Codecov by Sentry. |
This was referenced Nov 23, 2023
struan
force-pushed
the
multiple-geometry-staging
branch
2 times, most recently
from
e53be2b to
40908c3
Compare
Closed
|
Noting for the new year – I’m getting a 500 error on the staging site, when I try to load the area page for a new constituency: |
|
I've ficed the above error |
struan
force-pushed
the
multiple-geometry-staging
branch
from
6bec7e1 to
59a6179
Compare
zarino
force-pushed
the
multiple-geometry-staging
branch
from
77f4a56 to
5138236
Compare
struan
force-pushed
the
multiple-geometry-staging
branch
2 times, most recently
from
da939f7 to
9cfd95a
Compare
Fill the existing constituencies with the correct AreaType (2010 parliamentary constituencies)
Note that this does currently break the table and map
This is to ensure urls work as expected
mostly to default the area_type
Otherwise you end up with no areas returned if you select a dataset that's not available for the area type Fixes #335
This is off by default. This also removes the annoying survey message
deletes new cons data, also prints a message and respects quiet setting for converter
Include averages for both area types in filter list and then select the correct one client side when processing the data
If a user is logged in they are a member so can access non public datasets
also update tests for this
Part of #383 snagging.
struan
force-pushed
the
multiple-geometry-staging
branch
from
6f6901f to
7df2e5f
Compare
Partly as this avoids issues with matching multiple constituencies and also to avoid multiple person objects being returned for an area. Fixes #410
Not sure why this is happening. Fix from: chartjs/Chart.js#5805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is purely a staging branch for all the multiple geometry stuff to go into once reviewed so we don't have a load of long running interdependent PRs