Respect area type in filters

[struan]

This handles both the back end task only filtering on available filters for the area type, and also the front end of indicating when a selected filter type is not available when switching area types.

This also updates the filter list to indicate if a filter is available for the current area type.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (228f87c) 82.82% compared to head (50570ce) 82.93%.

Additional details and impacted files

@@                     Coverage Diff                      @@
##           256-multiple-geographies     #344      +/-   ##
============================================================
+ Coverage                     82.82%   82.93%   +0.10%     
============================================================
  Files                            90       92       +2     
  Lines                          2725     2742      +17     
  Branches                        278      279       +1     
============================================================
+ Hits                           2257     2274      +17     
  Misses                          404      404              
  Partials                         64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zarino]

I’ve added a fixup commit that simplifies the styling for the "unavailable" filters (no need to show the form controls, if they’ll have no effect). I guess this same styling / markup will need to be replicated for the shaders in the shaderContainer, and the columns in the columnContainer (which currently has no areas_available logic at all).

I‘ve also added a commit that generates the list of area type <option>s from data on the JavaScript side, rather than being hard-coded in the HTML markup. Felt like that’s more along the lines of the way the rest of the logic on this page works – but feel free to revert it, if it’s not suitable.

One more thing that needs fixing, I think, is that datasets should only appear in the "Add dataset" or "Add shader" modals if they apply to the current area type. No sense in displaying datasets that people can’t/shouldn’t choose. We’ll need to do this filtering before the favouriteDatasets, featuredDatasets, and otherDatasets arrays are passed to add-data-modal.html, so that any "empty" arrays are properly skipped.

[zarino]

Bit tricky to test this out locally as I don’t have any WMC23-only datasets, but from what I can see, this looks good to go 👍

[struan]

merged into #350