Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle switching area type on explore page when filters/shaders already selected #336

Closed
Tracked by #256
struan opened this issue Nov 7, 2023 · 2 comments
Closed
Tracked by #256

handle switching area type on explore page when filters/shaders already selected #336

struan opened this issue Nov 7, 2023 · 2 comments
Assignees
@struan
Labels
new constituencies priority
Milestone
New constituencies

Comments

@struan
Copy link
Member

struan commented Nov 7, 2023 •
edited
Loading

Ideally this should transparently switch to filtering using the new area type but will ideally need handling for filters that do not work with new area type - mostly to indicate to the user that the filter is not available so will not be applied.
@struan struan mentioned this issue Nov 7, 2023
Closed
8 tasks
struan added a commit that referenced this issue Nov 9, 2023
@struan
indicate if filters are unavailable for an area type
4289de1 
Include area types available with filter list returned from server and
use this to highlight is a filter isn't available for the chosen
area type

Part of #336
struan added a commit that referenced this issue Nov 9, 2023
@struan
indicate if filters are unavailable for an area type
2bc9ed1 
Include area types available with filter list returned from server and
use this to highlight is a filter isn't available for the chosen
area type

Part of #336
@zarino
Copy link
Member

zarino commented Nov 20, 2023

This is being / has been addressed as part of #344

struan added a commit that referenced this issue Nov 21, 2023
@struan
indicate if filters are unavailable for an area type
77dd0c7 
Include area types available with filter list returned from server and
use this to highlight is a filter isn't available for the chosen
area type

Part of #336
@zarino
Copy link
Member

zarino commented Nov 23, 2023

@struan I think this can be closed now, as #344 has been merged into #350 / multiple-geometry-staging?

@struan struan closed this as completed Nov 23, 2023
struan added a commit that referenced this issue Dec 6, 2023
@struan
indicate if filters are unavailable for an area type
8f6e235 
Include area types available with filter list returned from server and
use this to highlight is a filter isn't available for the chosen
area type

Part of #336
struan added a commit that referenced this issue Dec 11, 2023
@struan
indicate if filters are unavailable for an area type
637c397 
Include area types available with filter list returned from server and
use this to highlight is a filter isn't available for the chosen
area type

Part of #336
struan added a commit that referenced this issue Jan 11, 2024
@struan
indicate if filters are unavailable for an area type
6b0a52f 
Include area types available with filter list returned from server and
use this to highlight is a filter isn't available for the chosen
area type

Part of #336
struan added a commit that referenced this issue Jan 22, 2024
@struan
indicate if filters are unavailable for an area type
9dfb422 
Include area types available with filter list returned from server and
use this to highlight is a filter isn't available for the chosen
area type

Part of #336
struan added a commit that referenced this issue Jan 22, 2024
@struan
indicate if filters are unavailable for an area type
f566f7b 
Include area types available with filter list returned from server and
use this to highlight is a filter isn't available for the chosen
area type

Part of #336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@struan struan

Labels
new constituencies priority
Projects
None yet
Milestone
New constituencies
Development

No branches or pull requests
2 participants
@struan @zarino