Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix altercollectionfield interceptor dbname #38662

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 23, 2024

fix altercollectionfield interceptor dbname
issue: #37436

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 23, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 23, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 23, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Dec 23, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Dec 23, 2024

rerun go-sdk

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (bb5f38e) to head (433451e).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38662      +/-   ##
==========================================
+ Coverage   81.02%   81.03%   +0.01%     
==========================================
  Files        1380     1380              
  Lines      195145   195150       +5     
==========================================
+ Hits       158115   158143      +28     
+ Misses      31448    31435      -13     
+ Partials     5582     5572      -10     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.01% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/database_interceptor.go 96.24% <100.00%> (+0.07%) ⬆️

... and 24 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 23, 2024
@sre-ci-robot sre-ci-robot merged commit d718bbb into milvus-io:master Dec 23, 2024
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 24, 2024
fix altercollectionfield interceptor dbname
issue: #37436
master pr: #38662

Signed-off-by: Xianhui.Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants