Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4]fix altercollectionfield interceptor dbname #38664

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 23, 2024

fix altercollectionfield interceptor dbname
issue:
master pr: #38662

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

@JsDove Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.38%. Comparing base (7363a1c) to head (dc242e1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38664      +/-   ##
==========================================
- Coverage   80.38%   80.38%   -0.01%     
==========================================
  Files        1077     1077              
  Lines      169449   169454       +5     
==========================================
- Hits       136219   136217       -2     
- Misses      28748    28768      +20     
+ Partials     4482     4469      -13     
Files with missing lines Coverage Δ
internal/proxy/database_interceptor.go 96.24% <100.00%> (+0.07%) ⬆️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 23, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Dec 24, 2024

issue: #37436

@czs007 czs007 added the manual-pass manually set pass before ci-passed labeled label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/missing-related-issue kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants