Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5]fix altercollectionfield interceptor dbname #38663

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 23, 2024

fix altercollectionfield interceptor dbname
issue: #37436
master pr: #38662

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (bb3d993) to head (8af695b).
Report is 1 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38663       +/-   ##
===========================================
+ Coverage   69.35%   81.02%   +11.67%     
===========================================
  Files         292     1381     +1089     
  Lines       26187   195099   +168912     
===========================================
+ Hits        18162   158083   +139921     
- Misses       8025    31436    +23411     
- Partials        0     5580     +5580     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.33% <ø> (-0.02%) ⬇️
Go 83.00% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/proxy/database_interceptor.go 96.24% <100.00%> (ø)

... and 1089 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 23, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 24, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c51b458 into milvus-io:2.5 Dec 24, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants