Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to replicate collection when the services contains the system tt msg #37559

Merged
merged 4 commits into from
Dec 17, 2024
Merged

feat: support to replicate collection when the services contains the system tt msg #37559

merged 4 commits into from
Dec 17, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 9, 2024 •
edited
Loading

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file labels Nov 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 9, 2024

@SimFG

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@SimFG SimFG force-pushed the master-tt-step branch 14 times, most recently from b760c50 to c3a3c17 Compare November 22, 2024 08:57
@SimFG SimFG force-pushed the master-tt-step branch 5 times, most recently from 3b0542e to b6201b5 Compare November 23, 2024 13:22
@SimFG SimFG mentioned this pull request Nov 27, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 5, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 5, 2024
@jaime0815 jaime0815 added this to the 2.5.0 milestone Dec 13, 2024
@mergify mergify bot removed the ci-passed label Dec 13, 2024
@mergify mergify bot added the ci-passed label Dec 13, 2024
xiaofan-luan
xiaofan-luan reviewed Dec 14, 2024
View reviewed changes
pkg/util/merr/errors.go Outdated Show resolved Hide resolved
pkg/mq/msgstream/mq_msgstream.go Outdated Show resolved Hide resolved
internal/proxy/task.go Show resolved Hide resolved
@mergify mergify bot removed the ci-passed label Dec 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 15, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2afe2ea into milvus-io:master Dec 17, 2024
20 checks passed
@bigsheeper bigsheeper mentioned this pull request Dec 17, 2024
Merged
jaime0815 pushed a commit that referenced this pull request Dec 17, 2024
@bigsheeper
fix: Fix compile error (#38510)
01fa2f8 
/kind improvement

related: #37559

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved area/dependency Pull requests that update a dependency file area/internal-api ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SimFG @xiaofan-luan @sre-ci-robot @jaime0815