feat: add replicate.enable property to collection and related config #37106

SimFG · 2024-10-24T07:56:32Z

issue: [Feature]: support replication type collection and normal collection coexist #37105

sre-ci-robot · 2024-10-24T07:57:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mergify · 2024-10-24T08:30:51Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-24T09:31:58Z

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify · 2024-10-24T09:49:42Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-28T09:11:00Z

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify · 2024-10-28T09:33:44Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-29T02:51:07Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-10-29T02:51:20Z

/run-cpu-e2e

mergify · 2024-10-29T03:27:10Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-29T07:19:11Z

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-10-29T07:19:12Z

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify · 2024-10-29T07:20:35Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-10-29T07:29:49Z

rerun go-sdk

SimFG · 2024-10-29T07:29:57Z

/run-cpu-e2e

SimFG · 2024-10-29T07:30:07Z

rerun cpp-unit-test

mergify · 2024-10-29T07:42:23Z

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify · 2024-10-29T07:44:30Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-29T07:44:30Z

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-10-29T08:47:47Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-10-30T06:15:59Z

/run-cpu-e2e

SimFG · 2024-10-30T06:40:35Z

/run-cpu-e2e

mergify · 2024-10-30T07:16:35Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-10-30T07:28:50Z

/run-cpu-e2e

mergify · 2024-10-30T08:02:53Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-30T08:36:59Z

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-10-30T08:43:07Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-10-30T09:22:11Z

/run-cpu-e2e

mergify · 2024-10-30T09:57:08Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-10-30T11:05:39Z

/run-cpu-e2e

mergify · 2024-10-30T11:40:54Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-10-30T13:07:19Z

/run-cpu-e2e

mergify · 2024-10-30T13:51:25Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-11-05T06:53:59Z

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-11-05T07:15:21Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-05T08:09:08Z

/run-cpu-e2e

mergify · 2024-11-05T08:55:55Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-05T12:45:47Z

rerun ut

SimFG · 2024-11-06T01:59:26Z

/run-cpu-e2e

mergify · 2024-11-06T02:29:05Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: SimFG <[email protected]>

mergify · 2024-11-06T09:29:11Z

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-11-06T09:42:04Z

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

SimFG · 2024-11-06T11:24:57Z

rerun ut

xiaofan-luan · 2024-11-09T01:59:40Z

internal/proxy/task_insert.go

@@ -125,6 +125,15 @@ func (it *insertTask) PreExecute(ctx context.Context) error {
 		return merr.WrapErrAsInputError(merr.WrapErrParameterTooLarge("insert request size exceeds maxInsertSize"))
 	}

+	info, err := globalMetaCache.GetCollectionInfo(it.ctx, it.insertMsg.GetDbName(), collectionName, 0)


GetCollectionInfo && GetCollectionSchema twice might not be slow. and why do we need a Baisc Collection info?

we can do getFullCollectionInfo so base info and schema is there

SimFG · 2024-11-27T03:16:26Z

see the pr: feat: support to replicate collection when the services contains the system tt msg #37559

sre-ci-robot requested review from bigsheeper and czs007 October 24, 2024 07:56

sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 24, 2024

mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Oct 24, 2024

SimFG force-pushed the master branch from 5a673d4 to 4abe4e5 Compare October 24, 2024 09:16

SimFG force-pushed the master branch from 4abe4e5 to 38fe7b0 Compare October 28, 2024 08:57

sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 28, 2024

SimFG force-pushed the master branch from 38fe7b0 to c87b04f Compare October 29, 2024 02:09

SimFG force-pushed the master branch from c87b04f to 178dc60 Compare October 29, 2024 07:06

SimFG force-pushed the master branch from 712ff58 to 34d42b4 Compare October 30, 2024 08:04

SimFG force-pushed the master branch from 34d42b4 to 92588f7 Compare November 5, 2024 06:29

feat: add replicate.enable property to collection and related config

215e355

Signed-off-by: SimFG <[email protected]>

SimFG force-pushed the master branch from 92588f7 to 215e355 Compare November 6, 2024 08:36

xiaofan-luan reviewed Nov 9, 2024

View reviewed changes

SimFG closed this Nov 27, 2024

feat: add replicate.enable property to collection and related config #37106

feat: add replicate.enable property to collection and related config #37106

Conversation

SimFG commented Oct 24, 2024

sre-ci-robot commented Oct 24, 2024

mergify bot commented Oct 24, 2024

mergify bot commented Oct 24, 2024

mergify bot commented Oct 24, 2024

mergify bot commented Oct 28, 2024

mergify bot commented Oct 28, 2024

mergify bot commented Oct 29, 2024

SimFG commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

SimFG commented Oct 29, 2024

SimFG commented Oct 29, 2024

SimFG commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

SimFG commented Oct 30, 2024

SimFG commented Oct 30, 2024

mergify bot commented Oct 30, 2024

SimFG commented Oct 30, 2024

mergify bot commented Oct 30, 2024

mergify bot commented Oct 30, 2024

mergify bot commented Oct 30, 2024

SimFG commented Oct 30, 2024

mergify bot commented Oct 30, 2024

SimFG commented Oct 30, 2024

mergify bot commented Oct 30, 2024

SimFG commented Oct 30, 2024

mergify bot commented Oct 30, 2024

mergify bot commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 5, 2024

mergify bot commented Nov 5, 2024

SimFG commented Nov 5, 2024

SimFG commented Nov 6, 2024

mergify bot commented Nov 6, 2024

mergify bot commented Nov 6, 2024

mergify bot commented Nov 6, 2024

SimFG commented Nov 6, 2024

xiaofan-luan Nov 9, 2024

Choose a reason for hiding this comment

xiaofan-luan Nov 9, 2024

Choose a reason for hiding this comment

SimFG commented Nov 27, 2024