Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix compile error #38510

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: Fix compile error #38510

merged 1 commit into from
Dec 17, 2024

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Dec 17, 2024 •
edited by congqixia
Loading

/kind improvement

related: #37559

@bigsheeper
fix: Fix compile error
5a8d8ea 
Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Dec 17, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bigsheeper
Copy link
Contributor Author

image

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

@bigsheeper Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815 jaime0815 added manual-pass manually set pass before ci-passed labeled ci-passed labels Dec 17, 2024
@jaime0815 jaime0815 merged commit 01fa2f8 into milvus-io:master Dec 17, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@yhmo yhmo Awaiting requested review from yhmo

Assignees
No one assigned
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug kind/improvement Changes related to something improve, likes ut and code refactor manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigsheeper @sre-ci-robot @jaime0815