fix: update clang-tidy and clang-format from 10 to 12 #33141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiangyinzuo Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
mergify
bot
added
kind/bug
|
@jiangyinzuo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
mergify
bot
added
dco-passed
sre-ci-robot
added
size/S
jiangyinzuo
commented
May 18, 2024
internal/core/run_clang_format.sh
Outdated
| @@ -6,8 +6,15 @@ else | |||
| fi | |||
| CorePath=$1 | |||
|
|
|||
| # Check if clang-format-10 exists | |||
| if command -v clang-format-10 >/dev/null 2>&1; then | |||
There was a problem hiding this comment.
I am not sure whether we can replace all the clang-format-10 with clang-format in the codebase. So I write a simple check here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33141 +/- ##
==========================================
- Coverage 81.94% 81.93% -0.01%
==========================================
Files 1015 1015
Lines 130213 130213
==========================================
- Hits 106701 106694 -7
- Misses 19529 19535 +6
- Partials 3983 3984 +1 |
|
Thanks for your contribution. Not specifying clang format version may lead to unpredictable results. Could you also modify the files as shown in #33173, please? |
jiangyinzuo
commented
May 20, 2024
|
The integration test finds a DATA RACE, which appears to be unrelated to this PR. |
|
@czs007 Can you help rerun this? |
mergify
bot
added
needs-dco
|
@jiangyinzuo Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
jiangyinzuo
changed the title
-10 suffix for clang-tidy and clang-format in install_deps.sh
jiangyinzuo
force-pushed
the
patch-1
branch
2 times, most recently
from
6ff36df to
63089a7
Compare
Default llvm toolchain version in Ubuntu 20.04 is 10, while Ubuntu 22.04 does not have `clang-tidy-10` or `clang-format-10` by default. Upgrade clang-format and clang-tidy from 10 to 12, so that both Ubuntu 20.04 and 22.04 are able to run. See milvus-io#33173 issue: milvus-io#33142 Co-authored-by: Patrick Weizhi Xu <[email protected]> Signed-off-by: Patrick Weizhi Xu <[email protected]> Signed-off-by: Yinzuo Jiang <[email protected]>
|
@PwzXxm @XuanYang-cn @yhmo CI has passed, can we proceed now? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, jiangyinzuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yellow-shine
pushed a commit
to yellow-shine/milvus
that referenced
this pull request
Jul 2, 2024
Default llvm toolchain version in Ubuntu 20.04 is 10, while Ubuntu 22.04 does not have `clang-tidy-10` or `clang-format-10` by default. issue: milvus-io#33142 Signed-off-by: Patrick Weizhi Xu <[email protected]> Signed-off-by: Yinzuo Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default llvm toolchain version in Ubuntu 20.04 is 10, while Ubuntu 22.04 does not have
clang-tidy-10orclang-format-10by default.issue: #33142