enhance: Upgrade clang-format clang-tidy version #33173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Weizhi Xu <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PwzXxm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33173 +/- ##
==========================================
+ Coverage 82.17% 82.23% +0.06%
==========================================
Files 1009 1009
Lines 128822 128822
==========================================
+ Hits 105856 105942 +86
+ Misses 18961 18886 -75
+ Partials 4005 3994 -11 |
|
Wait for #33141 |
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this pull request
May 20, 2024
…eps.sh Default llvm toolchain version in Ubuntu 20.04 is 10, while Ubuntu 22.04 does not have `clang-tidy-10` or `clang-format-10` by default. Upgrade clang-format and clang-tidy from 10 to 12, so that both Ubuntu 20.04 and 22.04 are able to run. See milvus-io#33173 issue: milvus-io#33142 Signed-off-by: Yinzuo Jiang <[email protected]> Signed-off-by: Patrick Weizhi Xu <[email protected]> Co-authored-by: Patrick Weizhi Xu <[email protected]>
|
Close cuz duplicated with #33141 |
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this pull request
Jun 4, 2024
Default llvm toolchain version in Ubuntu 20.04 is 10, while Ubuntu 22.04 does not have `clang-tidy-10` or `clang-format-10` by default. Upgrade clang-format and clang-tidy from 10 to 12, so that both Ubuntu 20.04 and 22.04 are able to run. See milvus-io#33173 issue: milvus-io#33142 Signed-off-by: Yinzuo Jiang <[email protected]> Signed-off-by: Patrick Weizhi Xu <[email protected]> Co-authored-by: Patrick Weizhi Xu <[email protected]>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this pull request
Jun 4, 2024
Default llvm toolchain version in Ubuntu 20.04 is 10, while Ubuntu 22.04 does not have `clang-tidy-10` or `clang-format-10` by default. Upgrade clang-format and clang-tidy from 10 to 12, so that both Ubuntu 20.04 and 22.04 are able to run. See milvus-io#33173 issue: milvus-io#33142 Co-authored-by: Patrick Weizhi Xu <[email protected]> Signed-off-by: Yinzuo Jiang <[email protected]> Signed-off-by: Patrick Weizhi Xu <[email protected]>
jiangyinzuo
added a commit
to jiangyinzuo/milvus
that referenced
this pull request
Jun 4, 2024
Default llvm toolchain version in Ubuntu 20.04 is 10, while Ubuntu 22.04 does not have `clang-tidy-10` or `clang-format-10` by default. Upgrade clang-format and clang-tidy from 10 to 12, so that both Ubuntu 20.04 and 22.04 are able to run. See milvus-io#33173 issue: milvus-io#33142 Co-authored-by: Patrick Weizhi Xu <[email protected]> Signed-off-by: Patrick Weizhi Xu <[email protected]> Signed-off-by: Yinzuo Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #33142
Upgrade clang-format and clang-tidy from 10 to 12, so that both Ubuntu 20.04 and 22.04 are able to run