-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pwrmgr, top_darjeeling] Take external SoC reset into account in FSM #22575
Conversation
0258b20
to
c1835b6
Compare
16de381
to
c058079
Compare
054551d
to
a9c7ca9
Compare
ddc55ec
to
288afb2
Compare
288afb2
to
faabfac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can work, but we need to check and change a few things before merging, and then create some issues to follow up on
1. Internally generated reset request passed to SoC. 2. Create a sticky assertion internally to log request. Sticky flag cleared only upon external reset deassertion. 3. SoC transfers this request to platform to assert external reset. 4. External SoC reset deasserts after some time. 5. Pwrmgr stays in FastPwrStateRstWait state until the external SoC reset deasserts. 6. Boot / reset sequence continues. 7. Also fixes the external reset signal glitch filter to use the por reset. This is required to make sure that the external reset state does not self-reset once asserted and faithfully forwards that state to pwrmgr. 8. Added some debug visibility signals for pwrmgr. 9. Added temporary reset loop back path in pwrmgr TB to translate internal reset req from OT --> ext reset from SoC to OT. Needs a proper fix in testbench (issue lowRISC#22710). Signed-off-by: Neeraj Upasani <[email protected]>
c690b02
to
26c9ba7
Compare
CHANGE AUTHORIZED: hw/ip/pwrmgr/rtl/pwrmgr.sv |
Sticky flag cleared only upon external reset deassertion.
reset deasserts.
reset. This is required to make sure that the external reset state
does not self-reset once asserted and faithfully forwards that state
to pwrmgr.
internal reset req from OT --> ext reset from SoC to OT. Needs a
proper fix in testbench (issue [pwrmgr, top_darjeeling] Model external reset request in block- and top-level DV #22710).