[sival,flash_ctrl] complete flash_ctrl sival #20865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdonjdon
commented
Jan 18, 2024
•
jdonjdon
commented
- Porting selective tests(see commits below for detail)
- flash_ctrl_test.c
- flash_ctrl_ops_test.c
- flash_ctrl_clock_freqs_test.c
- flash_ctrl_idle_low_power_test.c
- flash_ctrl_mem_protection_test.c
- Update testplan with bazel target
- address issue [bazel] targets in sw/device/tests failing on cw310 and verilator when built by bazel #12486
jdonjdon
requested review from
timothytrippel,
moidx,
msfschaffner and
a-will
and removed request for
a team
jdonjdon
force-pushed
the
flash_ctrl_port_to_sival
branch
3 times, most recently
from
c7f8eff to
f89afde
Compare
timothytrippel
approved these changes
Jan 20, 2024
|
probably want to cherry pick these to the sival branch too |
a-will
approved these changes
Jan 20, 2024
- remove silicon_creator target - resolve conflict with rom_ext setup Signed-off-by: Jaedon Kim <[email protected]>
- disable info_region and otp access functions for silicon rom ext test - other minor clean up Signed-off-by: Jaedon Kim <[email protected]>
- mask info and bank0 test Signed-off-by: Jaedon Kim <[email protected]>
Adjust aon timer bark/bite threshold Signed-off-by: Jaedon Kim <[email protected]>
skip default region program Signed-off-by: Jaedon Kim <[email protected]>
update testplan with bazel target. Porting selective tests to sival. resolve issue lowRISC#12486 Signed-off-by: Jaedon Kim <[email protected]>
jdonjdon
force-pushed
the
flash_ctrl_port_to_sival
branch
from
f89afde to
5fe7e6d
Compare
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.