Add build instructions for windows #41
Merged
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavidIfebueme amazing work thanks! I have added a couple of comments |
|
@kuronosec not sure why but i cant see the comments on the readme. |
kuronosec
requested changes
Jan 4, 2025
README.md
Outdated
| ```bash | ||
| git clone https://github.com/kuronosec/zk-firma-digital | ||
| git clone https://github.com/yourusername/zk-firma-digital.git |
There was a problem hiding this comment.
Why "yourusername" and not the original repo?
README.md
Outdated
| cd zk-firma-digital | ||
| ``` | ||
|
|
||
|
|
There was a problem hiding this comment.
Maybe you can delete a couple of empty lines.
README.md
Outdated
|
|
||
|
|
||
| ### 2. Run the Build Script | ||
| While in the oot directory of the cloned repository and run the build by executing the Windows build script: |
@DavidIfebueme ups sorry I hadn't sent the review |
…om/DavidIfebueme/zk-firma-digital into add-build-instructions-for-windows
|
i've applied all the advised changes @kuronosec |
|
@DavidIfebueme I just changed the destination branch to dev (take this in account next time) and then approved it, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some instructions for building on a windows machine. tooling around mingw based git bash to run build sh script, pyinstaller for building the exe and Inno setup.
tested on my end (a windows machine) to ensure .exe was created in the /build.
please review. thanks :)