Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find out why the desktop app is being blocked by Antiviruses in Windows #42

Open
kuronosec opened this issue Jan 3, 2025 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@kuronosec
Copy link
Owner

As described in #41 with BitDefender and also seem with Avast in another testing machine, the windows version is being flagged by antivirus tools. Lets find the reason for that and how to fix it.

@kuronosec kuronosec added the good first issue Good for newcomers label Jan 3, 2025
@DavidIfebueme
Copy link
Contributor

can i investigate this as well.

@aidenwong812
Copy link

Is it okay if I tackle this?

@kuronosec
Copy link
Owner Author

can i investigate this as well.

@DavidIfebueme please go ahead

@DavidIfebueme
Copy link
Contributor

hi @kuronosec, i'm investigating this and first when running the build_windows.sh script, the installer.iss expects a zk-artifacts dir to be generated but its not. shouldn't we add a line in build_windows.sh to mkdir /build/zk-artifacts or skip in installer.iss if not necessary.

then, each time i try to run the actual .exe that has been built, there's an error showing there's a module i need to install first. please, is there a requirements.txt that i can just use to install all dependencies at once so i can move forward.

@kuronosec
Copy link
Owner Author

hey @DavidIfebueme

hi @kuronosec, i'm investigating this and first when running the build_windows.sh script, the installer.iss expects a zk-artifacts dir to be generated but its not. shouldn't we add a line in build_windows.sh to mkdir /build/zk-artifacts or skip in installer.iss if not necessary.

Yeah please add the directory creation in the script.

then, each time i try to run the actual .exe that has been built, there's an error showing there's a module i need to install first. please, is there a requirements.txt that i can just use to install all dependencies at once so i can move forward.

Could you add the error log here so I can see it? thanks!

@DavidIfebueme
Copy link
Contributor

@kuronosec

Yeah please add the directory creation in the script.

will do

Could you add the error log here so I can see it? thanks!

Traceback (most recent call last):
  File "main.py", line 25, in <module>
  File "PyInstaller\loader\pyimod02_importers.py", line 384, in exec_module
  File "certificate.py", line 6, in <module>
ModuleNotFoundError: No module named 'asn1crypto'

@kuronosec
Copy link
Owner Author

@kuronosec

Yeah please add the directory creation in the script.

will do

Could you add the error log here so I can see it? thanks!

Traceback (most recent call last):
  File "main.py", line 25, in <module>
  File "PyInstaller\loader\pyimod02_importers.py", line 384, in exec_module
  File "certificate.py", line 6, in <module>
ModuleNotFoundError: No module named 'asn1crypto'

hmm that's strange its in requirements.txt:

cat src/requirements.txt
asn1crypto==1.5.1
certvalidator==0.11.1
PyJWT==2.9.0
PyKCS11==1.5.17
PyQt6==6.7.1
PyQt6_sip==13.8.0
https://github.com/wbond/oscrypto/archive/d5f3437ed24257895ae1edd9e503cfb352e635a8.zip
web3==7.4.0
cryptography

maybe we need to add a instruction to install such dependencies:

pip install -r requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants