Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Training operator SDK unit test #1938

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Training operator SDK unit test #1938

merged 6 commits into from
Nov 21, 2023

Conversation

deepanker13
Copy link
Contributor

@deepanker13 deepanker13 commented Oct 26, 2023 •
edited
Loading

What this PR does / why we need it:

  1. Added bug fix in gen-sdk.sh
  2. Added unit test for create_job function of training client. Using purest library for unit testing. Total 13 test cases are there for the create_job function.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Partially implements #1924

Checklist:

  • Docs included if any changes are user facing

@deepanker13 deepanker13 mentioned this pull request Oct 26, 2023
Closed
@coveralls
Copy link

coveralls commented Oct 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6931302249

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 42.79%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 10 80.48%
Totals Coverage Status
Change from base Build 6723816999: -0.1%
Covered Lines: 3745
Relevant Lines: 8752
💛 - Coveralls

@deepanker13 deepanker13 changed the title adding bug fix in gen-sdk.sh and unit test for create_job function in… Training operator SDK unit test Oct 27, 2023
andreyvelich
andreyvelich reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the unit test @deepanker13.
I left a few comments.

sdk/python/test/sdk_unittest/test_training_client.py Outdated Show resolved Hide resolved
sdk/python/test/sdk_unittest/test_training_client.py Outdated Show resolved Hide resolved
sdk/python/test/sdk_unittest/test_training_client.py Outdated Show resolved Hide resolved
tenzen-y
tenzen-y reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm.

sdk/python/test/sdk_unittest/test_training_client.py Outdated Show resolved Hide resolved
@deepanker13
Copy link
Contributor Author

Thank you for adding the unit test @deepanker13.
I left a few comments.

@andreyvelich @tenzen-y please review it again, I have updated the code

@deepanker-gupta
Copy link

Thank you for adding the unit test @deepanker13.
I left a few comments.

@andreyvelich @tenzen-y please review it again, I have updated the code

Hi, @andreyvelich @tenzen-y any update on this?

andreyvelich
andreyvelich reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this @deepanker13!
Just a small comments.

sdk/python/kubeflow/training/api/test_training_client_create_job.py Outdated Show resolved Hide resolved
sdk/python/kubeflow/training/api/test_training_client_create_job.py Outdated Show resolved Hide resolved
tenzen-y
tenzen-y reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

@deepanker13
Copy link
Contributor Author

@andreyvelich I have addressed the comments.

@andreyvelich
Copy link
Member

Thank you @deepanker13!
/lgtm
/assign @johnugeorge @tenzen-y @droctothorpe

@google-oss-prow Google OSS Prow
Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: droctothorpe.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Thank you @deepanker13!
/lgtm
/assign @johnugeorge @tenzen-y @droctothorpe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added the lgtm label Nov 20, 2023
tenzen-y
tenzen-y reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

.github/workflows/test-python.yaml Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 21, 2023
@deepanker13
Copy link
Contributor Author

@andreyvelich @tenzen-y I have made all the suggested changes.

tenzen-y
tenzen-y reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepanker-gupta Thank you for great contribution!
/lgtm
/approve

@kubeflow/wg-training-leads Could you approve CI?

@google-oss-prow google-oss-prow bot added the lgtm label Nov 21, 2023
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepanker13, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e2d6ba4 into kubeflow:master Nov 21, 2023
2 checks passed
@andreyvelich andreyvelich mentioned this pull request Jan 24, 2024
Closed
11 tasks
@andreyvelich andreyvelich added this to the v0.8.0 Release milestone Jan 24, 2024
@andreyvelich andreyvelich mentioned this pull request Oct 8, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@andreyvelich andreyvelich andreyvelich left review comments

@droctothorpe droctothorpe droctothorpe left review comments

@johnugeorge johnugeorge johnugeorge left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@johnugeorge johnugeorge

@andreyvelich andreyvelich

@tenzen-y tenzen-y

Labels
approved lgtm release/1.8 size/L
Projects
None yet
Milestone
v0.8.0 Release
Development

Successfully merging this pull request may close these issues.
7 participants
@deepanker13 @coveralls @deepanker-gupta @andreyvelich @johnugeorge @droctothorpe @tenzen-y