Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Add unit test for Training Operator Python SDK #1924

Closed
andreyvelich opened this issue Sep 29, 2023 · 12 comments
Closed

[SDK] Add unit test for Training Operator Python SDK #1924

andreyvelich opened this issue Sep 29, 2023 · 12 comments

Comments

@andreyvelich
Copy link
Member

As we discussed before: #1919 (comment), we need to add unit test for our Training Operator Python SDK.

/area sdk
/good-first-issue

@google-oss-prow
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

As we discussed before: #1919 (comment), we need to add unit test for our Training Operator Python SDK.

/area sdk
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreyvelich andreyvelich changed the title [SDK] Add unit test for Training Operator [SDK] Add unit test for Training Operator Python SDK Sep 29, 2023
@yekxp
Copy link

yekxp commented Sep 30, 2023

Hello, my name is Jakub and I am a student of Technical University in Kosice and software developer in Siemens Healthineers and I would be very happy if I could work on this issue. It would be the part of the course where we have to help a project on GitHub. Could you assign me to it, please?

@johnugeorge
Copy link
Member

Thanks @yekxp for your interest. We are looking towards your contribution

@deepanker13
Copy link
Contributor

Hi @andreyvelich
Can you please confirm if the unit test needs to be added only for this file?
https://github.com/kubeflow/training-operator/blob/master/sdk/python/kubeflow/training/api/training_client.py

@deepanker13
Copy link
Contributor

Hi, @andreyvelich looking forward to hear from you

@andreyvelich
Copy link
Member Author

Sorry, I was on vacation @deepanker13.
Yes, that is correct, we need unit tests for methods in TrainingClient.
That would be great if you could help us with it.

@deepanker13
Copy link
Contributor

Thanks for confirming @andreyvelich

@deepanker13
Copy link
Contributor

deepanker13 commented Oct 26, 2023

@andreyvelich I have raised a PR to unit test create_job function
#1938

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member

/remove-lifecycle stale

@deepanker13 is working on this.
/assign @deepanker13

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member Author

This has been complete as part of: #1938.
We are looking for contributors to increase test coverage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment