-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python 3.6 support. #718
Remove python 3.6 support. #718
Conversation
Looks good to me! Only tiny thing I can see is that the test_admin file has an if statement checking if the Python version is >= 3.7 which I guess would now be innecesary, but I don't think it really matters. This is my first time contributing so I'm not sure how this works, should I submit a review approving the code changes? |
Yes please, once you approve it. I will merge it. Then you can rebase your pr to fix the failing 3.6 test. Then I will cut a release. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jamaalscarlet,
thank you for making this patch. Looking at @guspix comment and the updated change int the test,
# 3.6 adds a `,` to the string representation of the exception
python_version = sys.version_info[:2]
if python_version >= (3, 7):
error_message = "Some messages could not be processed: UnregisteredError('error')"
With that, I must say this looks good to me.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
==========================================
+ Coverage 70.28% 70.39% +0.10%
==========================================
Files 26 27 +1
Lines 1097 1101 +4
Branches 249 180 -69
==========================================
+ Hits 771 775 +4
Misses 288 288
Partials 38 38 ☔ View full report in Codecov by Sentry. |
* Remove python 3.6 support. * Remove unsupported code
* Remove python 3.6 support. * Remove unsupported code
No description provided.