Skip to content

Commit

Permalink
Remove python 3.6 support. (#718)
Browse files Browse the repository at this point in the history
* Remove python 3.6 support.

* Remove unsupported code
  • Loading branch information
jamaalscarlett authored Apr 27, 2024
1 parent 906fe52 commit 44977b1
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.6', '3.7', '3.8', '3.9']
python-version: ['3.7', '3.8', '3.9']

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ UPDATE_ON_DUPLICATE_REG_ID: Transform create of an existing Device (based on reg

Dependencies
------------
- Python 3.6+
- Python 3.7+
- Django 2.2+
- For the API module, Django REST Framework 3.7+ is required.
- For WebPush (WP), pywebpush 1.3.0+ is required (optional). py-vapid 1.3.0+ is required for generating the WebPush private key; however this
Expand Down
3 changes: 1 addition & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,14 @@ classifiers =
License :: OSI Approved :: MIT License
Programming Language :: Python
Programming Language :: Python :: 3
Programming Language :: Python :: 3.6
Programming Language :: Python :: 3.7
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Topic :: Internet :: WWW/HTTP
Topic :: System :: Networking

[options]
python_requires = >= 3.6
python_requires = >= 3.7
packages = find:
install_requires =
Django>=2.2
Expand Down
7 changes: 1 addition & 6 deletions tests/test_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,7 @@ def test_send_bulk_messages_action_fail(self):
self.assertEqual(message.token, "abc")
self.assertEqual(message.android.notification.body, "Test bulk notification")

# 3.6 adds a `,` to the string representation of the exception
python_version = sys.version_info[:2]
if python_version >= (3, 7):
error_message = "Some messages could not be processed: UnregisteredError('error')"
else:
error_message = "Some messages could not be processed: UnregisteredError('error',)"
error_message = "Some messages could not be processed: UnregisteredError('error')"

admin.message_user.assert_called_once_with(
request, error_message, level=messages.ERROR
Expand Down
3 changes: 1 addition & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
skipsdist = False
usedevelop = true
envlist =
py{36,37,38,39}-dj{22,32}
py{37,38,39}-dj{22,32}
py{38,39}-dj{40,405}
flake8

[gh-actions]
python =
3.6: py36
3.7: py37
3.8: py38
3.9: py39, flake8
Expand Down

0 comments on commit 44977b1

Please sign in to comment.