Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed firebase-admin's deprecated send_all method for send_each #715

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

guspix
Copy link
Contributor

@guspix guspix commented Apr 23, 2024

Closes #712. Let me know if I need to do anything else.

@guspix
Copy link
Contributor Author

guspix commented Apr 24, 2024

I can see that the Python 3.6 tests failed while the rest passed, since newer versions of firebase-admin support Python 3.7 and up. Can we remove support for 3.6, since it has been deprecated for over two years, or is that a deal breaker?

@jamaalscarlett
Copy link
Member

@guspix I have a PR dropping python 3.6 support #718

@jamaalscarlett
Copy link
Member

@guspix can I get a review on #718

@jamaalscarlett jamaalscarlett merged commit 0f79181 into jazzband:master Apr 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FCM send_all deprecated in favor of send_each/send_each_for_multicast, will stop working in June
2 participants