Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Kill nitro process with API - nitro 0.1.27 #975

Merged
merged 4 commits into from
Dec 13, 2023
Merged

feat: Kill nitro process with API - nitro 0.1.27 #975

merged 4 commits into from
Dec 13, 2023

Conversation

hiro-v
Copy link
Contributor

@hiro-v hiro-v commented Dec 13, 2023 •
edited
Loading

@hiro-v hiro-v added P0: critical Mission critical type: enhancement Improves a current feature type: feature request A new feature labels Dec 13, 2023
@hiro-v hiro-v added this to the Jan on Windows milestone Dec 13, 2023
@hiro-v hiro-v requested review from tikikun and louis-jan December 13, 2023 09:37
@hiro-v hiro-v self-assigned this Dec 13, 2023
louis-jan
louis-jan approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiro-v hiro-v merged commit b3405a6 into main Dec 13, 2023
@hiro-v hiro-v deleted the fix/kill_nitro branch December 13, 2023 10:17
@hahuyhoang411 hahuyhoang411 mentioned this pull request Dec 13, 2023
Closed
@louis-jan louis-jan mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@tikikun tikikun Awaiting requested review from tikikun

Assignees

@hiro-v hiro-v

Labels
P0: critical Mission critical type: enhancement Improves a current feature type: feature request A new feature
Projects
Jan & Cortex
Archived in project
Milestone
Jan Windows MVP
Development

Successfully merging this pull request may close these issues.
2 participants
@hiro-v @louis-jan