Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: app might take longer to load model since 0.4.0 #1069

Closed
Tracked by #1063
louis-jan opened this issue Dec 18, 2023 · 0 comments · Fixed by #1071
Closed
Tracked by #1063

bug: app might take longer to load model since 0.4.0 #1069

louis-jan opened this issue Dec 18, 2023 · 0 comments · Fixed by #1071
Assignees
@louis-jan
Labels
type: bug Something isn't working

Comments

@louis-jan
Copy link
Contributor

louis-jan commented Dec 18, 2023 •
edited
Loading

Describe the bug
Since #975 , app would wait for the kill nitro API finished before spawning a new process. The request could hang or failed after a few second.

To Reproduce
Steps to reproduce the behavior:

  1. Open app
  2. Start a thread
  3. Send a message
  4. Wait until model is loaded

Expected behavior
App should spawn Nitro immediately and load model. Should add timeout for the request.
@louis-jan louis-jan added P0: critical Mission critical type: bug Something isn't working labels Dec 18, 2023
@louis-jan louis-jan removed the P0: critical Mission critical label Dec 18, 2023
@louis-jan louis-jan changed the title bug: app take longer to load model since 0.4.0 bug: app might take longer to load model since 0.4.0 Dec 18, 2023
This was referenced Dec 18, 2023
Closed
Merged
@louis-jan louis-jan self-assigned this Dec 19, 2023
@freelerobot freelerobot moved this to Todo in Jan & Cortex Dec 19, 2023
@freelerobot freelerobot moved this from Todo to In Progress in Jan & Cortex Dec 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Jan & Cortex Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cache hallucinations and failed to load model due to race condition janhq/jan
1 participant
@louis-jan