Better world launch #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eminmeydanoglu
commented
Dec 7, 2024
| @@ -2,7 +2,7 @@ | |||
| <launch> | |||
| <arg name="gui" default="true" /> | |||
| <arg name="debug" default="false" /> | |||
| <arg name="world_name" default="$(find auv_sim_description)/worlds/seabed.world" /> | |||
| <arg name="world_name"/> | |||
There was a problem hiding this comment.
We already specify the default world in the main launch file. Why choose a default one here again? Deleted.
eminmeydanoglu
commented
Dec 7, 2024
| <node name="publish_world_models" pkg="uuv_assistants" type="publish_world_models.py" | ||
| output="screen"> | ||
| <node if="$(eval arg('world_name') == '$(find auv_sim_description)/worlds/seabed.world')" | ||
| name="publish_world_models" pkg="uuv_assistants" type="publish_world_models.py" |
There was a problem hiding this comment.
This node is only relevant to the seabed world. Dont need it at times we run a world that is not the seabed world.
eminmeydanoglu
commented
Dec 7, 2024
| @@ -1,13 +1,14 @@ | |||
| <?xml version="1.0"?> | |||
| <launch> | |||
| <env name="GAZEBO_MODEL_PATH" value="$(find auv_sim_description)/models:${GAZEBO_MODEL_PATH}"/> | |||
There was a problem hiding this comment.
Set gazebo model path automatically for everyone for convenience. Works as intended 👍
eminmeydanoglu
commented
Dec 7, 2024
| <arg name="use_gui" default="true" /> | ||
| <arg name="debug" default="false" /> | ||
| <arg name="world_name" default="$(find auv_sim_description)/worlds/seabed.world" /> | ||
| <arg name="world_name" default="$(find auv_sim_description)/worlds/pool.world" /> |
There was a problem hiding this comment.
Under normal circumstances, it is preferable to set the pool world as default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.