Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add delegate_collection_authority and revoke_collection_authority #77

Merged
merged 12 commits into from
Oct 22, 2024

Conversation

grandima
Copy link
Contributor

Closes #16 #17

This PR:

  • adds possibility to delegate and revoke collection authority to Helius SDK
  • adds example usage on how to delegate and revoke collection authority
  • changes MintApiAuthority associated value from &'static str to Pubkey

@0xIchigo
Copy link
Collaborator

This is extremely based @grandima ! I'm just wondering: do you have any real-world examples of delegating and revoking the collection authority, or is it just limited to the tests? I'll give this PR a more formal review soon — I am currently tied up with other dev work that's taking priority. Nonetheless, thank you for your contributions! 🔥

@grandima
Copy link
Contributor Author

grandima commented Oct 21, 2024

Thanks for acknowledgment!

No, I have not seen real-world examples. But I've included example usage in this PR.

Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely based! Thank you for taking the time to implement this! Everything looks good on my end 🔥


assert_ne!(
devnet_authority.unwrap(),
MintApiAuthority::Devnet("Blade"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only fitting that this is merged on the same day the new Blade movie is delayed indefinitely

@0xIchigo 0xIchigo merged commit c3b870e into helius-labs:dev Oct 22, 2024
1 check passed
@0xIchigo 0xIchigo mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add delegate_collection_authority
2 participants