-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add delegate_collection_authority and revoke_collection_authority #77
feat: Add delegate_collection_authority and revoke_collection_authority #77
Conversation
This is extremely based @grandima ! I'm just wondering: do you have any real-world examples of delegating and revoking the collection authority, or is it just limited to the tests? I'll give this PR a more formal review soon — I am currently tied up with other dev work that's taking priority. Nonetheless, thank you for your contributions! 🔥 |
Thanks for acknowledgment! No, I have not seen real-world examples. But I've included example usage in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is extremely based! Thank you for taking the time to implement this! Everything looks good on my end 🔥
|
||
assert_ne!( | ||
devnet_authority.unwrap(), | ||
MintApiAuthority::Devnet("Blade"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only fitting that this is merged on the same day the new Blade movie is delayed indefinitely
Closes #16 #17
This PR:
MintApiAuthority
associated value from&'static str
toPubkey