Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revoke_collection_authority #17

Closed
0xIchigo opened this issue May 15, 2024 · 4 comments
Closed

Add revoke_collection_authority #17

0xIchigo opened this issue May 15, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@0xIchigo
Copy link
Collaborator

In our Node.js SDK, we have the revokeCollectionAuthority method, which revokes collection authority from an address. This is handy when used with our Mint API. We should add this functionality to the Rust SDK

@0xIchigo 0xIchigo added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 15, 2024
@grandima
Copy link
Contributor

I tried to dig into this issue and I found that Node.js SDK uses Metaplex to make NFT requests under the hood. Should the solution to this issue rely on some Rust alternative library to Metaplex or write all the necessary code (structs, requests) in Rust SDK library?

@0xIchigo
Copy link
Collaborator Author

@grandima, I haven't dug into it yet so I'm not 100% sure. It hasn't been a huge priority, so it's your call — whatever works best!

@grandima
Copy link
Contributor

grandima commented Oct 15, 2024

@0xIchigo hey! The PR #77 is ready. Feel free to review.

It also contains changes to #16 because in order to test #17 #16 had to be implemented.

@0xIchigo
Copy link
Collaborator Author

Can we considered closed now that #77 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants