Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump solana to 2.0.x #80

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Bump solana to 2.0.x #80

merged 3 commits into from
Oct 23, 2024

Conversation

4lve
Copy link
Contributor

@4lve 4lve commented Oct 22, 2024

No description provided.

@0xIchigo
Copy link
Collaborator

gm @4lve ! Unfortunately, it doesn't look like this PR is building correctly. Would you be able to mirror #74 more closely as it seems the versions in there work

@4lve
Copy link
Contributor Author

4lve commented Oct 22, 2024

image
lol, for sure, will take a look at it

@0xIchigo
Copy link
Collaborator

And, of course, now it doesn't work with #77 merged, likely because of the inclusion of mpl-token-metadata and spl-token 💀 @4lve

@4lve
Copy link
Contributor Author

4lve commented Oct 22, 2024

Looks like this PR added spl-token, mpl-token-metadata into dependancies colliding with solana v2

@4lve
Copy link
Contributor Author

4lve commented Oct 22, 2024

Yep, we are doomed lol. this issue has been raised in mpl-token-metadata

@4lve
Copy link
Contributor Author

4lve commented Oct 22, 2024

Alr, found that a beta version of mpl-token-metadata support 2.0, I pushed

Copy link
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely based! Thank you for your contribution 🔥

@0xIchigo 0xIchigo merged commit 192e4db into helius-labs:dev Oct 23, 2024
1 check passed
This was referenced Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants