Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PNG network logos with vector drawables #238

Closed
patkan opened this issue Sep 30, 2016 · 11 comments · Fixed by #958
Closed

Replace PNG network logos with vector drawables #238

patkan opened this issue Sep 30, 2016 · 11 comments · Fixed by #958
Assignees
Labels
beginner job 🔰 This is a relatively easy task suitable for new contributors. enhancement 🏗️ A functional improvement.
Milestone

Comments

@patkan
Copy link
Contributor

patkan commented Sep 30, 2016

The transport network logos in the picker have different sizes. I think they should all be the same size.
How can this be accomplished? Simply rescaling the svg and then putting it through the exporter? I tried it, but it seemed to not always work.
And if they should all be the same size, then how large should they be?

@grote
Copy link
Owner

grote commented Sep 30, 2016

SVG logos should all have 64dpx64dp. If they don't have that, this can easily be changed in their XML file.

I suspect this issue to be really about updating the remaining raster graphics to SVG. Could that be it? If so, @nautilusx and @vinzv had started with that, but I haven't seen more PRs from them so far.

@grote grote added enhancement 🏗️ A functional improvement. needs info ℹ️ More information needed, labels Sep 30, 2016
@patkan
Copy link
Contributor Author

patkan commented Sep 30, 2016

And now I understand why some networks have magically a logo even when I could not find it. Yep, the problem is that the "false" sized networks PNGs are.

@grote grote changed the title Make network logos the same size Replace PNG network logos with SVGs Sep 30, 2016
@grote grote changed the title Replace PNG network logos with SVGs Replace PNG network logos with vector drawables Sep 30, 2016
@grote
Copy link
Owner

grote commented Sep 30, 2016

I updated the title of this issue to reflect that it is really about changing the graphics to vector drawables. The homepage has information on how to do that here: https://transportr.grobox.de/#contribute

@nautilusx
Copy link

It's on my to-do-list for October. I will create/update all other logos. Germany and Austria are done.

@patkan
Copy link
Contributor Author

patkan commented Oct 1, 2016

On my way through the transport networks I found the new logo for TFI in Ireland and created it. It's not perfect but if you start working on the logos I could give you this one. Alternatively feel free to pull it in, I have it in my fork of this repo.

@grote
Copy link
Owner

grote commented Oct 1, 2016

@patkan Please feel free to open a PR just for one logo if you have it already. What's done is done.

@grote grote removed the needs info ℹ️ More information needed, label Jan 7, 2017
@grote
Copy link
Owner

grote commented Jan 7, 2017

@nautilusx Any news?

@nautilusx
Copy link

nautilusx commented Jan 15, 2017

Here are the next 6 logos.
6xml.zip
6svg.zip

@grote
Copy link
Owner

grote commented Jan 15, 2017

Thanks a lot @nautilusx! Added in a1d509c.

@grote grote added the beginner job 🔰 This is a relatively easy task suitable for new contributors. label Jan 31, 2018
@grote
Copy link
Owner

grote commented Aug 14, 2018

New link is now here: https://transportr.app/contribute/#design

@ialokim ialokim added this to the 2.2 milestone Sep 8, 2020
@ialokim ialokim self-assigned this Sep 13, 2020
@Altonss
Copy link
Collaborator

Altonss commented Nov 2, 2024

Almost finished thanks to the changes made by @ialokim and merged in #956 !
Only networks remaining are Paris, rtachicago and se, see #590 (comment) by @ialokim :

Furthermore, I have been working on three more SVG logos (for paris, se and rtachicago), but while converting them to Android XML using SvgToVectorDrawableConverter, it seems the current minimum API version does not support gradients. How should we handle that case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner job 🔰 This is a relatively easy task suitable for new contributors. enhancement 🏗️ A functional improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants