Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hungary provider #451

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Added Hungary provider #451

merged 2 commits into from
Jul 26, 2018

Conversation

urbalazs
Copy link
Contributor

@urbalazs urbalazs commented Jun 2, 2018

Hi @grote
This PR added Hungary provider, included two cities: Budapest (capital city) and Miskolc.
Related PR: schildbach/public-transport-enabler#195

@cla-bot
Copy link

cla-bot bot commented Jun 2, 2018

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @urbalazs on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement.

@urbalazs
Copy link
Contributor Author

urbalazs commented Jun 2, 2018

I accept the CLA.

@grote
Copy link
Owner

grote commented Jun 3, 2018

Hey, thanks a lot for your contribution!

At the moment, the CI still fails. This is because the new provider is not yet included in the public transport enabler library. You can ask the people behind the staging library to merge it there if it doesn't get merged soon. Then you just need to update the reference to the library like it was done here: https://github.com/grote/Transportr/pull/448/files#diff-39e7d8c00954e920b98e7636f0ac30b2

grote added a commit that referenced this pull request Jun 16, 2018
@grote
Copy link
Owner

grote commented Jun 16, 2018

@cla-bot[bot] check

@cla-bot
Copy link

cla-bot bot commented Jun 16, 2018

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors. label Jun 16, 2018
@anjandev
Copy link
Contributor

anjandev commented Jul 1, 2018

Hey @urbalazs, I found that felix is super responsive to merging providers. Espically if you message him on xmpp using omemo:
https://felix.delattre.de/contact/

felix maintains this repo:
https://gitlab.com/opentransitmap/public-transport-enabler

Hope Hungary gets merged soon! :)

@pantierra
Copy link

Great to have Hungary soon in Transportr! I added the pull request to the staging repository. Cheers.

@urbalazs
Copy link
Contributor Author

Hi @grote
Hungary was added to the staging repository. Can you help me to merge my pull request? Sorry, but I don't know, what should I do to update the reference to the library.

@grote
Copy link
Owner

grote commented Jul 25, 2018

@mimi89999 might do it for you. Check the other pull requests.

name = R.string.np_name_hungary,
description = R.string.np_desc_hungary,
agencies = R.string.np_desc_hungary_networks,
logo = R.drawable.network_hungary_logo,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this? Looks like this logo doesn't actually get added. You need to transform the SVG into an AndroidVectorDrawable, see #238

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @grote
here is the Hungary logo in AndroidVectorDrawable format:

<?xml version="1.0" encoding="utf-8"?>
<vector xmlns:android="http://schemas.android.com/apk/res/android"
    android:viewportWidth="6"
    android:viewportHeight="3"
    android:width="64dp"
    android:height="64dp">
    <path
        android:pathData="M0 0L6 0 6 3 0 3Z"
        android:fillColor="#436f4d" />
    <path
        android:pathData="M0 0L6 0 6 2 0 2Z"
        android:fillColor="#ffffff" />
    <path
        android:pathData="M0 0L6 0 6 1 0 1Z"
        android:fillColor="#cd2a3e" />
</vector>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind adding it to your pull request?
It needs to go to app/src/main/res/drawable/network_hungary_logo.xml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@grote
Copy link
Owner

grote commented Jul 26, 2018

Wohoo! The CI passed now :)

Thanks for adding! Please understand that you'll be responsible for this Provider as I don't live in Hungary and can't maintain it myself.

@grote grote merged commit 0c66536 into grote:master Jul 26, 2018
@mimi89999 mimi89999 mentioned this pull request Jul 27, 2018
@grote grote mentioned this pull request Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed ✔️ The Contributor Licence Agreement was signed by all contributors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants