-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Hungary provider #451
Conversation
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @urbalazs on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. |
I accept the CLA. |
Hey, thanks a lot for your contribution! At the moment, the CI still fails. This is because the new provider is not yet included in the public transport enabler library. You can ask the people behind the staging library to merge it there if it doesn't get merged soon. Then you just need to update the reference to the library like it was done here: https://github.com/grote/Transportr/pull/448/files#diff-39e7d8c00954e920b98e7636f0ac30b2 |
@cla-bot[bot] check |
The cla-bot has been summoned, and re-checked this pull request! |
Hey @urbalazs, I found that felix is super responsive to merging providers. Espically if you message him on xmpp using omemo: felix maintains this repo: Hope Hungary gets merged soon! :) |
Great to have Hungary soon in Transportr! I added the pull request to the staging repository. Cheers. |
Hi @grote |
@mimi89999 might do it for you. Check the other pull requests. |
name = R.string.np_name_hungary, | ||
description = R.string.np_desc_hungary, | ||
agencies = R.string.np_desc_hungary_networks, | ||
logo = R.drawable.network_hungary_logo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this? Looks like this logo doesn't actually get added. You need to transform the SVG into an AndroidVectorDrawable, see #238
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @grote
here is the Hungary logo in AndroidVectorDrawable format:
<?xml version="1.0" encoding="utf-8"?>
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:viewportWidth="6"
android:viewportHeight="3"
android:width="64dp"
android:height="64dp">
<path
android:pathData="M0 0L6 0 6 3 0 3Z"
android:fillColor="#436f4d" />
<path
android:pathData="M0 0L6 0 6 2 0 2Z"
android:fillColor="#ffffff" />
<path
android:pathData="M0 0L6 0 6 1 0 1Z"
android:fillColor="#cd2a3e" />
</vector>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Would you mind adding it to your pull request?
It needs to go to app/src/main/res/drawable/network_hungary_logo.xml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Wohoo! The CI passed now :) Thanks for adding! Please understand that you'll be responsible for this Provider as I don't live in Hungary and can't maintain it myself. |
Hi @grote
This PR added Hungary provider, included two cities: Budapest (capital city) and Miskolc.
Related PR: schildbach/public-transport-enabler#195