Add Pl Navitia provider (Municipal Transports of Poland) #481
Conversation
|
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @mimi89999 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. |
| @@ -130,7 +130,7 @@ dependencies { | |||
| implementation "com.google.dagger:dagger:$daggerVersion" | |||
| kapt "com.google.dagger:dagger-compiler:$daggerVersion" | |||
|
|
|||
| implementation('com.gitlab.opentransitmap:public-transport-enabler:9c909718') { | |||
There was a problem hiding this comment.
Did you test this? Looks like you didn't update the dependency pinning. See #479 (comment) for more details!
There was a problem hiding this comment.
@grote You removed verification in 4bd5924#diff-39e7d8c00954e920b98e7636f0ac30b2
There was a problem hiding this comment.
Shall I add it back?
|
Oops! This was not intentional. Yes, please!
You could also bump the commit once more. A Hungary provider was added a few minutes ago.
|
|
Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @mimi89999 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. |
|
@grote I changed the commit, readded dependency pinning and signed CLA. |
|
Awesome! Thanks a lot! 😄 💐 |
|
@cla-bot[bot] check |
|
The cla-bot has been summoned, and re-checked this pull request! |
cla-bot
bot
added
the
cla-signed ✔️
|
I noticed the PNG logo too late. We are kind of not accepting those anymore. Would you mind replacing this with a VectorDrawable? See #238 |
|
The wiki said that PNG are OK. I will change that PNG for a drawable tomorrow. |
No description provided.