Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Massachusetts, USA Region #508

Closed
4 tasks done
xeniarose opened this issue Aug 14, 2018 · 4 comments
Closed
4 tasks done

Support for Massachusetts, USA Region #508

xeniarose opened this issue Aug 14, 2018 · 4 comments
Labels
beginner job 🔰 This is a relatively easy task suitable for new contributors. coverage 🗺️ This is related to the geographic areas supported. enhancement 🏗️ A functional improvement.

Comments

@xeniarose
Copy link

Acknowledgments
Please check the following boxes with an x if they apply:

  • The feature I want to propose would be useful for the majority of users, not only for me personally.
  • I am aware that Transportr is mostly developed by one person in their unpaid spare time.
  • I can help myself to get this feature implemented or know someone who wants to do it.
  • If I want to add support for a new region or country, I checked that this is already available in public-transport-enabler and know the process described on the Transportr homepage.

Is your feature request related to a problem? Please describe.
Transportr currently doesn't support any transportation in Massachusetts, USA

Describe the solution you'd like
Support for the above.

Describe alternatives you've considered
N/A

Additional context
I have a functioning PR to public-transport-enabler here:
schildbach/public-transport-enabler#219

Transportr patch (WIP) located here (I will open a PR when ready):
https://github.com/erikuhlmann/Transportr/tree/region-mass

@grote grote added enhancement 🏗️ A functional improvement. upstream 🏞️ Related to an upstream issue. coverage 🗺️ This is related to the geographic areas supported. labels Aug 14, 2018
@grote
Copy link
Owner

grote commented Aug 14, 2018

Awesome @erikuhlmann! Wish everybody would work like you :)

Tiny detail about the upcoming PR: Please don't use new PNG files. These should be replaces by vector images. See #238

@fibn144
Copy link

fibn144 commented Feb 13, 2019

Just to update this issue: The PR has been merged to public-transport-enabler.

Also, I've found SVG source for the PNG logo in this pull request: https://commons.wikimedia.org/wiki/File:Flag-map_of_Massachusetts.svg .
I converted it with https://a-student.github.io/SvgToVectorDrawableConverter.Web/ to get https://gist.github.com/fibn144/a99538fe80725a950e4fb7819c9da6d3 , but I don't know what I'm doing around Android development and so someone should sanity-check it because I haven't.

Also the SVG (and therefore the converted Android XML file) is CC-BY-SA in case that is an issue, although if it is then both of its two source images are public domain, and so a close equivalent can be easily recreated and released CC0.

If there's too much happening in the flag-map and you want a simpler one, here's just the flag by itself: https://gist.github.com/fibn144/475006c32da0323dac96e43b32f66df8

There are also easy ways to get the logos of the MassDOT, as well as the two different public transportation networks represented in the dataset, if that is preferable.

@ialokim
Copy link
Collaborator

ialokim commented Sep 6, 2020

Hi @fibn144, I think it would be nice to add this new region to Transportr as well. Are you still interested in working on this?

The flag itself would be better than the flag-map to have a simpler vector file - perhaps you could even try to simplify the paths further to get faster loading in Android?

@ialokim ialokim added beginner job 🔰 This is a relatively easy task suitable for new contributors. and removed upstream 🏞️ Related to an upstream issue. labels Sep 6, 2020
@ialokim
Copy link
Collaborator

ialokim commented Oct 7, 2023

Unfortunately Massachusetts is not served by Navitia anymore, see #877 (comment).

@ialokim ialokim closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner job 🔰 This is a relatively easy task suitable for new contributors. coverage 🗺️ This is related to the geographic areas supported. enhancement 🏗️ A functional improvement.
Projects
None yet
Development

No branches or pull requests

4 participants