Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review payment API #6

Closed
kamirr opened this issue Jul 26, 2023 · 4 comments
Closed

Review payment API #6

kamirr opened this issue Jul 26, 2023 · 4 comments
Assignees

Comments

@kamirr
Copy link
Contributor

kamirr commented Jul 26, 2023

How new Payment Driver align with YAGNA. What information we would like to get in YAGNA payment module.

Acceptance Criteria:

  • Review YAGNA API for interaction with Payment Driver
  • Review Payment Driver API
  • List of potential changes
@kamirr kamirr self-assigned this Jul 26, 2023
@kamirr kamirr changed the title Review API Review payment API Jul 26, 2023
@nieznanysprawiciel
Copy link

How does signing transactions works?
Previous driver calls identity api using GSB. In new driver I see that it must be initialized with private keys.
Not all identities will be unlocked on yagna start.

@golmek
Copy link

golmek commented Aug 3, 2023

Result of the Review: https://www.notion.so/golemnetwork/erc20_payment_lib-integration-API-review-bb14fd0d39df44599a1d180ab7d288a2?pvs=4

Summary of Recommendations:

@golmek
Copy link

golmek commented Aug 4, 2023

way of handling payment driver statuses:

  • event per invoice/debit note (payable) -> OK
  • New REST API Endpoint -> OK

-> golemfactory/yagna#2685

@kamirr
Copy link
Contributor Author

kamirr commented Aug 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants