Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Payment Driver (ERC20_NEXT) with yagna - STEP 1 #2673

Closed
5 tasks done
nieznanysprawiciel opened this issue Jul 27, 2023 · 4 comments · Fixed by #2710, golemfactory/erc20_payment_lib#43 or golemfactory/erc20_payment_lib#45
Assignees

Comments

@nieznanysprawiciel
Copy link
Contributor

nieznanysprawiciel commented Jul 27, 2023

Initial integration of Payment Driver with Yagna with supporting current API == Achieve feature parity.

What is more, payment driver should include an implementation of the Signer trait from payments lib that uses the signing facilities in yagna to sign the transaction (will require some tweaks in identity). It is necessary for erc20_payment_lib to sign transaction in Yagna

Acceptance criteria:

  • New Signer in ERC20_NEXT
    • Payment Driver can sign transaction with key hold in Yagna
  • Yagna is able to make payments using new driver
  • Create new subtasks when problems are identified
  • Propose next steps - Notion as tasks

Additional Information

@golmek golmek changed the title Integrate driver with yagna Integrate Payment Driver (ERC20_NEXT) with yagna Aug 7, 2023
@golmek golmek changed the title Integrate Payment Driver (ERC20_NEXT) with yagna Integrate Payment Driver (ERC20_NEXT) with yagna - STEP1 Aug 7, 2023
@golmek golmek changed the title Integrate Payment Driver (ERC20_NEXT) with yagna - STEP1 Integrate Payment Driver (ERC20_NEXT) with yagna - STEP 1 Aug 7, 2023
@scx1332
Copy link
Collaborator

scx1332 commented Aug 14, 2023

Included as step 1)

  1. Set proper localization for database file related to driver. Driver has one common database for all networks.
  2. Decide how to use payment_setup.toml when configuring yagna.
  3. Cleanup mess with logging. Right now erc20 library is logging probably excessively.

@golmek
Copy link
Contributor

golmek commented Aug 23, 2023

In progress:

Currently not working - troubleshooting in progress

@golmek
Copy link
Contributor

golmek commented Aug 25, 2023

Refactor needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants