Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Signer in ERC20_NEXT #2682

Closed
golmek opened this issue Aug 7, 2023 · 1 comment · Fixed by #2710
Closed

New Signer in ERC20_NEXT #2682

golmek opened this issue Aug 7, 2023 · 1 comment · Fixed by #2710

Comments

@golmek
Copy link
Contributor

golmek commented Aug 7, 2023 •
edited
Loading

Payment driver should include an implementation of the Signer trait from payments lib that uses the signing facilities in yagna to sign the transaction (will require some tweaks in identity). It is necessary for erc20_payment_lib to sign transaction in Yagna

Acceptance Criteria:

  • Payment Driver can sign transaction with key hold in Yagna
  • Verify sign from Yagna with yagna payment transfer

Additonal Information:
based on results of: golemfactory/erc20_payment_lib#6
@golmek golmek mentioned this issue Aug 7, 2023
Closed
@kamirr kamirr self-assigned this Aug 10, 2023
@kamirr kamirr linked a pull request Aug 18, 2023 that will close this issue
new payment driver integration #2710
Merged
@golmek
Copy link
Contributor Author

golmek commented Aug 21, 2023 •
edited
Loading

duplicate of: #2673
Closing this ticket

@golmek golmek closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

new payment driver integration golemfactory/yagna
2 participants
@kamirr @golmek