-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chore): typos found by eslint #2591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Dec 9, 2022
mvorisek
commented
Dec 9, 2022
mvorisek
commented
Dec 9, 2022
mvorisek
commented
Dec 9, 2022
mvorisek
commented
Dec 9, 2022
mvorisek
commented
Dec 9, 2022
mvorisek
commented
Dec 9, 2022
auto-assign
bot
requested review from
ColinFrick,
exoego,
y0hami,
ko2in,
lubber-de and
prudho
December 9, 2022 12:42
This was referenced Dec 9, 2022
lubber-de
approved these changes
Dec 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lubber-de
changed the title
Fix smelly typos found by eslint
fix(chore): typos found by eslint
Dec 10, 2022
lubber-de
added
type/bug
Any issue which is a bug or PR which fixes a bug
type/chore
Anything which is a project chore
type/ci
Anything related to CI/CD
javascript
Pull requests that update Javascript code
labels
Dec 10, 2022
mvorisek
added a commit
to mvorisek/Fomantic-UI
that referenced
this pull request
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
type/bug
Any issue which is a bug or PR which fixes a bug
type/chore
Anything which is a project chore
type/ci
Anything related to CI/CD
type/lint
eslint / stylelint related changes only
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixed lines were identified by eslint when developing #2589.
As the changes are fixing bugs (and thus change behaviour) or can potentially have side effects, they are made as a separate PR.