Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint): fix global-require eslint rule #2588

Merged
merged 2 commits into from
Dec 25, 2022
Merged

feat(lint): fix global-require eslint rule #2588

merged 2 commits into from
Dec 25, 2022

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 5, 2022 •
edited
Loading

No description provided.

@mvorisek mvorisek mentioned this pull request Dec 5, 2022
Draft
@mvorisek mvorisek marked this pull request as ready for review December 5, 2022 14:47
@mvorisek mvorisek marked this pull request as draft December 6, 2022 12:21
lubber-de
lubber-de requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent reviewed all, yet but those 2 changes i wanted to report beforehand

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/nightly.yml Outdated Show resolved Hide resolved
@mvorisek mvorisek force-pushed the fui_2_9_airbnb branch 3 times, most recently from f8640f5 to 6f9213a Compare December 6, 2022 23:34
This was referenced Dec 7, 2022
Merged
Merged
@mvorisek mvorisek force-pushed the fui_2_9_airbnb branch 6 times, most recently from d403aa5 to 036e05f Compare December 16, 2022 14:29
@mvorisek mvorisek force-pushed the fui_2_9_airbnb branch 3 times, most recently from b0eba37 to 0debe3c Compare December 22, 2022 16:34
@mvorisek mvorisek changed the title Unify/modernize code with eslint Fix global-require eslint rule Dec 23, 2022
@mvorisek mvorisek marked this pull request as ready for review December 23, 2022 10:55
lubber-de
lubber-de approved these changes Dec 25, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de changed the title Fix global-require eslint rule feat(lint): fix global-require eslint rule Dec 25, 2022
@lubber-de lubber-de merged commit 3f3fee4 into fomantic:develop Dec 25, 2022
@lubber-de lubber-de added type/ci Anything related to CI/CD type/lint eslint / stylelint related changes only type/build Anything related to the build process and removed type/ci Anything related to CI/CD labels Dec 25, 2022
@lubber-de lubber-de added this to the 2.9.1 milestone Dec 25, 2022
@mvorisek mvorisek deleted the fui_2_9_airbnb branch December 25, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@exoego exoego Awaiting requested review from exoego

@y0hami y0hami Awaiting requested review from y0hami

@ko2in ko2in Awaiting requested review from ko2in

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
type/build Anything related to the build process type/lint eslint / stylelint related changes only
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @lubber-de