fix(chore): typos found by eslint

.eslintrc.js

@@ -104,6 +104,7 @@ module.exports = {
         semi: ['error'],
         'no-extra-semi': ['error'],
         'no-trailing-spaces': ['error'],
+        'array-callback-return': ['error', { allowImplicit: true }],
     },
     reportUnusedDisableDirectives: true,
 };

src/definitions/behaviors/api.js

@@ -157,11 +157,6 @@
                 },
                 write: {
                     cachedResponse: function (url, response) {
-                        if (response && response === '') {
-                            module.debug('Response empty, not caching', response);
-
-                            return;
-                        }
                         if (window.Storage === undefined) {
                             module.error(error.noStorage);
 

src/definitions/behaviors/visibility.js

@@ -246,8 +246,8 @@
                     ;
                     while (imagesLength--) {
                         cacheImage = document.createElement('img');
-                        cacheImage.onload = handleLoad;
-                        cacheImage.onerror = handleLoad;
+                        cacheImage.addEventListener('load', handleLoad);
+                        cacheImage.addEventListener('error', handleLoad);
                         cacheImage.src = images[imagesLength];
                         cache.push(cacheImage);
                     }

src/definitions/modules/calendar.js

@@ -885,7 +885,7 @@
                         var endDate = module.get.endDate();
                         if (!!endDate && !!date && date > endDate) {
                             // selected date is greater than end date in range, so clear end date
-                            module.set.endDate(undefined);
+                            module.set.endDate();
                         }
                         module.set.dataKeyValue(metadata.date, date);
 
@@ -1022,7 +1022,7 @@
                 },
 
                 clear: function () {
-                    module.set.date(undefined);
+                    module.set.date();
                 },
 
                 popup: function () {
@@ -1721,7 +1721,7 @@
                         }
                         for (j = 0; j < settings.text.months.length; j++) {
                             monthString = settings.text.months[j];
-                            monthString = monthString.substring(0, word.length).toLowerCase();
+                            monthString = monthString.slice(0, word.length).toLowerCase();
                             if (monthString === word) {
                                 month = j + 1;
 

src/definitions/modules/dropdown.js

@@ -2391,7 +2391,7 @@
                         $nextSelectedItem
                             .addClass(className.selected)
                         ;
-                        if (settings.selectOnKeydown && module.is.single() && !$nextItem.hasClass(className.actionable)) {
+                        if (settings.selectOnKeydown && module.is.single() && !$nextSelectedItem.hasClass(className.actionable)) {
                             module.set.selectedItem($nextSelectedItem);
                         }
                         $menu

src/definitions/modules/popup.js

@@ -1497,12 +1497,12 @@
                     html   = '',
                     escape = $.fn.popup.settings.templates.escape
                 ;
-                if (typeof text !== undefined) {
-                    if (typeof text.title !== undefined && text.title) {
+                if (text !== undefined) {
+                    if (text.title) {
                         text.title = escape(text.title);
                         html += '<div class="header">' + text.title + '</div>';
                     }
-                    if (typeof text.content !== undefined && text.content) {
+                    if (text.content) {
                         text.content = escape(text.content);
                         html += '<div class="content">' + text.content + '</div>';
                     }

src/definitions/modules/progress.js

@@ -606,7 +606,7 @@
                         }
                     },
                     barLabel: function (text) {
-                        $progresses.map(function (index, element) {
+                        $progresses.each(function (index, element) {
                             var $progress = $(element);
                             if (text !== undefined) {
                                 $progress.text(module.get.text(text, index));

src/definitions/modules/search.js

@@ -1356,7 +1356,7 @@
 
         regExp: {
             escape: /[\-\[\]\/\{\}\(\)\*\+\?\.\\\^\$\|]/g,
-            beginsWith: '(?:\s|^)',
+            beginsWith: '(?:\\s|^)',
         },
 
         // maps api response attributes to internal representation

tasks/docs/metadata.js

@@ -53,7 +53,7 @@ function parser(file, callback) {
             /** @type {string} */
             text     = String(file.contents.toString('utf8')),
             lines    = text.split('\n'),
-            filename = file.path.substring(0, file.path.length - 4),
+            filename = file.path.slice(0, -4),
             key      = 'server/documents',
             position = filename.indexOf(key)
         ;
@@ -66,7 +66,7 @@ function parser(file, callback) {
             return callback(null, file);
         }
 
-        filename = filename.substring(position + key.length + 1, filename.length);
+        filename = filename.slice(position + key.length + 1, filename.length);
 
         var
             lineCount = lines.length,