Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert icon helper to Typescript #2360

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Convert icon helper to Typescript #2360

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff1b208
Convert icon helper to Typescript
lhsazevedo Oct 5, 2020
f81fbdb
Use namespaced Mithril import for consistency
lhsazevedo Oct 5, 2020
c53d42c
Remove unnecessary JSDoc types from icon helper
lhsazevedo Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions js/src/common/helpers/icon.js → js/src/common/helpers/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import * as Mithril from 'mithril';

/**
* The `icon` helper displays an icon.
*
* @param {String} fontClass The full icon class, prefix and the icon’s name.
* @param {Object} attrs Any other attributes to apply.
* @return {Object}
* @param {Mithril.Attributes} attrs Any other attributes to apply.
dsevillamartin marked this conversation as resolved.
Show resolved Hide resolved
* @return {Mithril.Vnode}
*/
export default function icon(fontClass, attrs = {}) {
export default function icon(fontClass: string, attrs: Mithril.Attributes = {}): Mithril.Vnode {
attrs.className = 'icon ' + fontClass + ' ' + (attrs.className || '');

return <i {...attrs} />;
Expand Down